Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_psm3 interval description #1712

Merged
merged 2 commits into from
Apr 8, 2023
Merged

Update get_psm3 interval description #1712

merged 2 commits into from
Apr 8, 2023

Conversation

AdamRJensen
Copy link
Member

  • Closes get_psm3 with tmy will not ignore interval #1702
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Updates the description of the interval parameter in the pvlib.iotools.get_psm3 function. See #1702.

@AdamRJensen AdamRJensen added documentation io remote-data triggers --remote-data pytests labels Apr 6, 2023
mikofski
mikofski approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@mikofski mikofski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mikofski mikofski merged commit 4c24be0 into pvlib:main Apr 8, 2023
@kandersolar kandersolar added this to the 0.10.0 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikofski mikofski mikofski approved these changes

Assignees
No one assigned
Labels
documentation io remote-data triggers --remote-data pytests
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

get_psm3 with tmy will not ignore interval
3 participants
@AdamRJensen @mikofski @kandersolar